Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use require instead of t.Fatal(err) in tests/integration package #18820

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix: use require instead of t.Fatal(err) in tests/integration package #18820

merged 1 commit into from
Feb 3, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 1, 2024 •
edited
Loading

Description

This uses testify instead of testing for t.Fatal calls

Related to #18972

@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorel-35
Copy link
Contributor Author

/assign @spzala

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 08a5213 to 502fdc1 Compare November 1, 2024 10:17
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (488f215) to head (91c0765).
Report is 27 commits behind head on main.

Additional details and impacted files

see 30 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18820      +/-   ##
==========================================
+ Coverage   68.84%   68.85%   +0.01%     
==========================================
  Files         420      420              
  Lines       35693    35693              
==========================================
+ Hits        24572    24576       +4     
+ Misses       9705     9689      -16     
- Partials     1416     1428      +12

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488f215...91c0765. Read the comment docs.

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch 3 times, most recently from dac8a24 to 2d99225 Compare November 1, 2024 10:44
@mmorel-35
Copy link
Contributor Author

/assign @ahrtr

@ahrtr
Copy link
Member

ahrtr commented Nov 1, 2024

/ok-to-test

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch 3 times, most recently from 458fd16 to 3385c23 Compare November 1, 2024 13:40
@ahrtr
Copy link
Member

ahrtr commented Nov 3, 2024

Please try to breakdown the PR. We love small PR to make the review easy, although this PR is just mechanical changes.
Thanks

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 3385c23 to fa2bd5d Compare November 3, 2024 20:24
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from fa2bd5d to 44eda63 Compare November 3, 2024 20:24
@mmorel-35
Copy link
Contributor Author

/test pull-etcd-integration-1-cpu-amd64

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch 4 times, most recently from 94c8c18 to 6d896a0 Compare November 8, 2024 23:36
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35 mmorel-35 marked this pull request as ready for review November 29, 2024 10:11
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch 2 times, most recently from c4ff93b to 6c560ab Compare November 30, 2024 10:02
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35 mmorel-35 mentioned this pull request Nov 30, 2024
Closed
14 tasks
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 6c560ab to 6a8afb9 Compare December 1, 2024 21:40
ahrtr
ahrtr requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please breakdown this PR to smaller ones, thanks

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 6a8afb9 to db069c0 Compare December 2, 2024 18:20
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from db069c0 to eb95361 Compare December 2, 2024 18:21
@mmorel-35 mmorel-35 requested a review from ahrtr December 2, 2024 18:36
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from eb95361 to 21e141d Compare December 11, 2024 06:59
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 21e141d to 116c8f3 Compare December 21, 2024 15:52
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 116c8f3 to 235041c Compare January 25, 2025 09:22
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 235041c to 9547cd6 Compare January 25, 2025 09:25
@mmorel-35
fix: use require instead of t.Fatal(err) in tests/integration package
91c0765 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 9547cd6 to 91c0765 Compare January 30, 2025 22:30
@mmorel-35
Copy link
Contributor Author

/retest

@ahrtr
Copy link
Member

ahrtr commented Feb 3, 2025

cc @fuweid @ivanvc @jmhbnz @serathius @siyuanfoundation

fuweid
fuweid approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit e6e4edd into etcd-io:main Feb 3, 2025
34 checks passed
@mmorel-35 mmorel-35 deleted the tests/integration/testifier/require-error branch February 3, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees

@spzala spzala

@ahrtr ahrtr

Labels
approved area/testing ok-to-test size/XL
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmorel-35 @k8s-ci-robot @codecov-commenter @ahrtr @fuweid @spzala