Fix debug sync log line #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Valdes <ivan@vald.es>
ahrtr
approved these changes
Feb 11, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.4 |
|
@ArkaSaha30 can you enable the cherry-pick for bbolt and raft? thx cc. @ivanvc |
k8s-ci-robot
pushed a commit
to kubernetes/test-infra
that referenced
this pull request
Feb 11, 2025
This commit enables cherrypicker and needs-rebase plugin on etcd.io/bbolt, etcd.io/raft. Ref: etcd-io/bbolt#904 (comment) Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
|
/cherry-pick release-1.4 |
|
@ahrtr: new pull request created: #905 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this while reviewing #898. The function called should be
Debugf, notDebug. I searched for all other functions, and this is the only instance where it's wrong.