Require switch blocks when declaring variables #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good, thanks! |
|
I just want to check - have you tested all of these apps since you made the changes to them? Because while I think this is a good thing, there may still be a possibility that wrapping the blocks has actually broken something if the code did actually use the defined variable later? |
|
I checked that the variables in the switch cases were only used in that case. I also tested a few apps on my watch just to make sure my approach was valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When declaring variables inside switch cases, the variables are also available in the other switch cases, with some special rules. This is basically never the intention, and can lead to weird bugs. I suggest requiring switch blocks when variables are declared, which limits the scope of the variable to the individual case.