Don't use octals #3187
Merged
Don't use octals #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Great find, sounds good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest disallowing 0-prefixed numbers in the official apps, as it is not allowed per the Ecmascript standard.
These numbers are disallowed because the original Ecmascript standard allowed some decimal numbers to be 0-prefixed, but also used the 0-prefix to encode octal numbers. Most of the time, octal numbers are simply converted to decimal numbers and everything is good, but sometimes these subtle differences lead to some very weird bugs. The newer strict Ecmascript standard therefore disallows 0-prefixed numbers completely to eliminate this class of bugs.