Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android.html: allow zooming in Gadgetbridge #3185

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

thinkpoop
Copy link
Contributor

Update to android.html (Gadgetbridge) to allow zooming in the embedded AppLoader.

Most browsers have a "Force enable zoom" option, but the embedded webview isn't affected by it.

Link: https://thinkpoop.github.io/BangleApps/android.html

@bobrippling
Copy link
Collaborator

Looks good - @gfwilliams was there a strong reason for the original attributes / any points before I merge?

@gfwilliams
Copy link
Member

If this is actually tested and works in Gadgetbridge, let's merge.

The main thing is to ensure that it forces readable font/button sizes and one column of apps. I think likely I just set the meta tag with the min/max because that's what I'd seen suggested for webviews and I didn't think people would really want to zoom anyway, but I don't really have strong opinions either way :)

@bobrippling bobrippling merged commit e792560 into espruino:master Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants