Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two app updates plus one new application #3147

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Conversation

pglez82
Copy link
Contributor

@pglez82 pglez82 commented Jan 4, 2024

Hi,

First of all, sorry if commits from different applications should not be together.

The two updates are very basic, the involve these two banglejs 1 apps (which I created):

  • Intervals: changed the configuration to allow intervals with a resolution of 1s instead of 5s.
  • Planeatarium: Added two new constellations.

The new application is for banglejs 2. It is called quoteclock. Basically, it's a clock that shows nice literary quotes every hour.

Best regards,
Pablo

@bobrippling
Copy link
Collaborator

Thanks - I think in this case one PR is fine for the three apps.

Just one request, would you mind moving quoteclock's setUI call above its Bangle.loadWidgets call? This'll handle the warning we're getting around there ("Clock quoteclock file calls loadWidgets before setUI (clock widget/etc won't be aware a clock app is running)")

@pglez82
Copy link
Contributor Author

pglez82 commented Jan 23, 2024

Sorry, I forgot about this completely. I have moved the call upwards and also formatted the code (sorry for posting unformatted code in my initial PR).

@bobrippling
Copy link
Collaborator

No worries - thanks for the changes :)

@bobrippling bobrippling merged commit 23a294d into espruino:master Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants