Merge pull request #3730 from voloved/counter2

Fix with counter2's default values in settings
espruino · Feb 2, 2025 · 99e8485 · 99e8485
2 parents c74c99a + 5323f83
commit 99e8485
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/apps/counter2/ChangeLog b/apps/counter2/ChangeLog
@@ -2,3 +2,4 @@
 0.02: Added Settings & readme
 0.03: Fix lint warnings
 0.04: Fix lint warnings
+0.05: Fix on not reading counter defaults in Settings
diff --git a/apps/counter2/metadata.json b/apps/counter2/metadata.json
@@ -1,7 +1,7 @@
 {
   "id": "counter2",
   "name": "Counter2",
-  "version": "0.04",
+  "version": "0.05",
   "description": "Dual Counter",
   "readme":"README.md",
   "icon": "counter2-icon.png",

diff --git a/apps/counter2/settings.js b/apps/counter2/settings.js
@@ -18,15 +18,15 @@
         "": { "title": "Counter2" },
         "< Back": () => back(),
         'Default C1': {
-            value: settings[0],
+            value: settings.max0,
             min: -99, max: 99,
             onchange: v => {
                 settings.max0 = v;
                 writeSettings();
             }
         },
         'Default C2': {
-            value: settings[2],
+            value: settings.max1,
             min: -99, max: 99,
             onchange: v => {
                 settings.max1 = v;