ci: update this-danger arguments

espressif · Dec 1, 2023 · e7a60c1 · e7a60c1
1 parent 4feab04
commit e7a60c1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/danger-this.yml b/.github/workflows/danger-this.yml
@@ -23,3 +23,6 @@ jobs:
       run: npx danger --dangerfile=src/dangerfile.ts ci
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        CONTRIBUTING_GUIDE_FILE: 'CONTRIBUTING.md'
+        MAX_COMMITS: '7'
+        MAX_COMMITS_WARN: '9'
diff --git a/src/outputInstructions.ts b/src/outputInstructions.ts
@@ -27,11 +27,10 @@ export default async function (): Promise<void> {
 
 	// Contributors guide link, if exists in the repository
 	if (config.instructions.contributingGuideFile) {
-		const contributionsGuideLink = `https://github.com/${repositoryOwner}/${repositoryName}/blob/${await getDefaultBranch()}/${
-			config.instructions.contributingGuideFile
-		}`;
+		const defaultBranch = await getDefaultBranch();
+		const contributionsGuideLink = `https://github.com/${repositoryOwner}/${repositoryName}/blob/${defaultBranch}/${config.instructions.contributingGuideFile}`;
 		instructions += `<hr>`;
-		instructions += `📘 Please review the project's <a href="${contributionsGuideLink}}">Contributions Guide</a> for key guidelines on code, documentation, testing, and more.<br>`;
+		instructions += `📘 Please review the project's <a href="${contributionsGuideLink}">Contributions Guide</a> for key guidelines on code, documentation, testing, and more.<br>`;
 	}
 
 	// Contributor License Agreement, if provided link to it