Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames wpa2_enterprise in README.md. (IDFGH-11816) #12910

Closed
wants to merge 1 commit into from

Conversation

aadsm
Copy link

@aadsm aadsm commented Jan 2, 2024

Renames wpa2_enterprise to wifi_enterprise.

Renames `wpa2_enterprise` to `wifi_enterprise`.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented Jan 2, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Renames wpa2_enterprise in README.md.":
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ The Pull Request description looks very brief, please check if more details can be added.

👋 Hello aadsm, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 86a63f5

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 2, 2024
@github-actions github-actions bot changed the title Renames wpa2_enterprise in README.md. Renames wpa2_enterprise in README.md. (IDFGH-11816) Jan 2, 2024
@aadsm
Copy link
Author

aadsm commented Jan 2, 2024

Oh never mind. I don't think I can sign your CLA because of clause "3.1 Patent License". Your CLA's scope is larger than just my "Contribution", it's "the Contribution and the Contribution in combination with the Material (and portions of such combination)". It's tricky because as stated in the CLA: '"Material" means the software or documentation made available by Us to third parties.'.
This leads me to believe that if in the future any part of your "Material" (and not just my "Contribution") infringes on my "patents owned or controlled by [me], whether already acquired or hereafter acquired" I would have no means to protect myself.
If this is not the case could you clarify please?

Not a big deal though, as this is a super simple change anyone can implement in a couple of seconds.

@kapilkedawat
Copy link
Collaborator

this change is not needed in latest master anymore.

@aadsm aadsm closed this Mar 20, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants