Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes/Improvements for media player #37

Merged
merged 19 commits into from
Aug 5, 2024

Conversation

kahrendt
Copy link
Contributor

@kahrendt kahrendt commented Aug 5, 2024

This PR adds some improvements and fixes a lot of outstanding issues with the current media player.

  • Bugfix: Disabled the new special-case FIR based resampler due to random crashes
  • Bugfix: Audio pipeline correctly reports its state
  • Bugfix: FLAC decoding is more robust - it can properly handle running out of data mid-frame
  • Bugfix: Fixes some pointer logic with regards to the decoders input buffer - mainly showed up at higher sample rates
  • Bugfix: Improves memory handling in resampler - should avoid going past the allocated buffers when converting mono to stereo or upsampling
  • Improvement: The DAC mute state is read on boot
  • Improvement: Logs what element failed if the pipeline breaks
  • Improvement: Fails gracefully if the incoming stream can't be processed (too many channels or incomptable bits per sample)
  • Improvement: Configurable output sample rate - useful for experimental 48kHz XMOS firmware
  • Improvement: Update TODOs and added a verbose description to nabu_media_player.cpp of how the code is organized and the typical workflow of the media player

@kahrendt kahrendt marked this pull request as draft August 5, 2024 15:15
@kahrendt kahrendt marked this pull request as ready for review August 5, 2024 15:16
@kahrendt kahrendt merged commit dd7fd38 into dev Aug 5, 2024
4 checks passed
@kahrendt kahrendt deleted the kahrendt-20240801-media-player-fixes branch August 5, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants