Add fast-connect substitution. Ignore one more error state. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Firmware built successfully! 🎉 Download and extract the firmware to install with https://web.esphome.io Make sure to choose |
|
Substitutions are not required for this kind of thing. Once someone has taken control, they can add this to the minimal yaml to achieve the same wifi:
fast_connect: trueIt will merge with the wifi configuration. |
|
I think the substitution is better (really a personal opinion) because we can comment on it and guide the user to turn something to true. But yeah. 100% agreed it's literally faster your way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hidden SSID
A substitution called
hidden_ssidwas added for people who have hidden SSID.Taking control will still be necessary.
I think documentation will have to be updated
Ignored Error state.
If you trigger the VPE but do not talk.
The VPE yields a
stt-no-text-recognized.This PR ignores it for the "Red flashes", so the device silently goes back to idle without flashing.