Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add restart button to home-assistant-voice.yaml" #298

Closed
wants to merge 1 commit into from

Conversation

balloob
Copy link
Member

@balloob balloob commented Jan 19, 2025

There is no normal operations use case for restarting the Voice PE. We shouldn't add features "because we can".

Reverts #273

Copy link

Firmware built successfully! 🎉

Download and extract the firmware to install with https://web.esphome.io

Make sure to choose home-assistant-voice-esp32s3.factory.bin.

@the-mentor
Copy link
Contributor

the-mentor commented Jan 19, 2025

There are a bunch of use cases that require device reboot

Lets say I change a dhcp reservation and want to remotely apply the change to the device.

Or if I change dns settings on my router and I want the device to get them.

I see what you are saying about adding features just because you can
I just don't think a reboot is not a resonable option to have

Here is the original issue
#270

@tbrasser
Copy link

Also its disabled by default, so why revert?

Usecase: have single ssid "mesh" (wired backbone), esp32's don't seem to roam/connect to closest AP when something happens to them (e.g. AP firmware update doesn't connect back to it after coming online again), remote reboot is needed. (or does this wifi config have fast bss / roaming enabled? That should also work for this usecase if the network is configured as such)

@RocketRammer
Copy link

There are a bunch of use cases that require device reboot

Lets say I change a dhcp reservation and want to remotely apply the change to the device.

Or if I change dns settings on my router and I want the device to get them.

I see what you are saying about adding features just because you can I just don't think a reboot is not a resonable option to have

Here is the original issue #270

Yep this. My DNS fell over the other other. Fixed it. Then noticed both my Voice PE's were sat with a red ring of death. Had to manually unplug them like some 90's hardware.

Crazy not to add this.

I understand the approach of not doing things just because you can, however I'd challenge that with what harm does this bring? Zero. If people don't need it, they won't use it, but it's there for the people that do.

@balloob balloob closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants