Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix media commands before wifi #196

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Conversation

kahrendt
Copy link
Contributor

Fixes a crash when sending media player commands before wifi is connected by increasing the setup priority and directly checking if the component is ready before handling a command.

This fixes it on the media player side, but a similar bug currently exists in the i2s_audio speaker that will still cause a crash. That bug is fixed in esphome/esphome#7759.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kahrendt kahrendt marked this pull request as ready for review November 13, 2024 13:55
Copy link

Firmware built successfully! 🎉

Download and extract the firmware to install with https://web.esphome.io

Make sure to choose home-assistant-voice-esp32s3.factory.bin.

Copy link

Firmware built successfully! 🎉

Download and extract the firmware to install with https://web.esphome.io

Make sure to choose home-assistant-voice-esp32s3.factory.bin.

@kahrendt kahrendt enabled auto-merge (squash) November 18, 2024 03:04
@balloob balloob disabled auto-merge November 18, 2024 03:05
@balloob balloob merged commit 23c7297 into dev Nov 18, 2024
7 checks passed
@balloob balloob deleted the bugfix-media-commands-before-wifi branch November 18, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants