Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for M5Stack Fire #538

Merged
merged 8 commits into from
Oct 30, 2023
Merged

Conversation

landonr
Copy link
Contributor

@landonr landonr commented Oct 19, 2023

No description provided.

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit fa397ed
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/653fb3d7a2dccb0008fdde71
😎 Deploy Preview https://deploy-preview-538--esphome-devices.netlify.app/devices/m5stack-fire
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 2 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 83 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@abmantis abmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue (at least of the M5GO when the bottom is plugged) that causes wifi issues (like not connecting) if GPIO15 is not setup.
Maybe it makes sense to add that note somewhere, in case people try to use this without setting up the side lights and then pull their hair out wondering why it won't connect.

An alternative to setting up the side lights is just:

  - platform: gpio
    id: wifi_fix_output
    pin: GPIO15

src/docs/devices/M5Stack-Fire/index.md Outdated Show resolved Hide resolved
src/docs/devices/M5Stack-Fire/index.md Outdated Show resolved Hide resolved
@landonr
Copy link
Contributor Author

landonr commented Oct 24, 2023

There is an issue (at least of the M5GO when the bottom is plugged) that causes wifi issues (like not connecting) if GPIO15 is not setup. Maybe it makes sense to add that note somewhere, in case people try to use this without setting up the side lights and then pull their hair out wondering why it won't connect.

An alternative to setting up the side lights is just:

  - platform: gpio
    id: wifi_fix_output
    pin: GPIO15

I don't understand this one @abmantis

@landonr landonr marked this pull request as ready for review October 29, 2023 13:37
@landonr
Copy link
Contributor Author

landonr commented Oct 29, 2023

There is an issue (at least of the M5GO when the bottom is plugged) that causes wifi issues (like not connecting) if GPIO15 is not setup. Maybe it makes sense to add that note somewhere, in case people try to use this without setting up the side lights and then pull their hair out wondering why it won't connect.

An alternative to setting up the side lights is just:

  - platform: gpio
    id: wifi_fix_output
    pin: GPIO15

can you suggest an edit that I can paste in?

Co-authored-by: Abílio Costa <abmantis@users.noreply.github.com>
@tekmaven tekmaven merged commit 4f524b8 into esphome:main Oct 30, 2023
5 checks passed
@landonr landonr deleted the lando/m5stackfire branch October 30, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants