Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shelly 3EM. #499

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Add Shelly 3EM. #499

merged 3 commits into from
Feb 28, 2024

Conversation

kpfleming
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit 0250d01
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/6585aa90d120560008bfc8ad
😎 Deploy Preview https://deploy-preview-499--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 83 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kpfleming kpfleming marked this pull request as draft August 14, 2023 12:03
@tekmaven
Copy link
Collaborator

This looks ready to me, but is marked as a Draft. Are there any other changes you were going to make? If yes, one option is that we can accept this and you can make future PRs to update the page.

@kpfleming
Copy link
Contributor Author

I'll leave it 'draft' until the ade7880 component has been included in an EPSHome release. It's waiting for its first review, so it could be some time before that happens.

@Habbie
Copy link
Contributor

Habbie commented Dec 16, 2023

The relevant PR is esphome/esphome#5242 (and it is still open)

@kpfleming kpfleming marked this pull request as ready for review February 20, 2024 11:55
@kpfleming
Copy link
Contributor Author

The code has been merged into ESPHome 'dev' for the next release, so this can be merged at any time.

@tekmaven tekmaven merged commit 8d16836 into esphome:main Feb 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants