From 493728e3116cf6ac43cb310216a4eb87986f862a Mon Sep 17 00:00:00 2001 From: Hiroki SAKABE Date: Thu, 16 Feb 2023 13:25:21 +0000 Subject: [PATCH 1/2] =?UTF-8?q?mypy=E3=81=AE--warn-unused-ignores=E3=82=92?= =?UTF-8?q?=E6=9C=89=E5=8A=B9=E5=8C=96?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- lambda/app/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lambda/app/Makefile b/lambda/app/Makefile index 2ddc78f8..f3212801 100644 --- a/lambda/app/Makefile +++ b/lambda/app/Makefile @@ -24,7 +24,7 @@ lint-check: .PHONY: type-check type-check: - pipenv run mypy . --disallow-untyped-calls --disallow-any-generics --disallow-untyped-decorators + pipenv run mypy . --disallow-untyped-calls --disallow-any-generics --disallow-untyped-decorators --warn-unused-ignores .PHONY: test test: export AWS_DEFAULT_REGION := us-east-1 From 7ebb75f8823ca16c026210afe02520e2767eec94 Mon Sep 17 00:00:00 2001 From: Hiroki SAKABE Date: Thu, 16 Feb 2023 13:25:39 +0000 Subject: [PATCH 2/2] =?UTF-8?q?mypy=E3=81=AE--warn-unused-ignores=E3=81=A7?= =?UTF-8?q?=E3=82=A8=E3=83=A9=E3=83=BC=E3=81=AB=E3=81=AA=E3=82=8B=E7=AE=87?= =?UTF-8?q?=E6=89=80=E3=82=92=E4=BF=AE=E6=AD=A3?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- lambda/app/bee_slack_app/view/home.py | 8 ++++---- lambda/app/bee_slack_app/view/post_review.py | 8 ++++---- lambda/app/bee_slack_app/view/read_review.py | 14 +++++++------- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/lambda/app/bee_slack_app/view/home.py b/lambda/app/bee_slack_app/view/home.py index f4428ae2..16f00085 100644 --- a/lambda/app/bee_slack_app/view/home.py +++ b/lambda/app/bee_slack_app/view/home.py @@ -127,7 +127,7 @@ def home( # pylint: disable=too-many-locals { "type": "mrkdwn", "text": f"*現在のレビュー投稿数 {total_review_count}件*", - }, # type:ignore + }, ], }, { @@ -210,7 +210,7 @@ def home( # pylint: disable=too-many-locals { "type": "actions", "elements": [ - { # type: ignore + { "type": "button", "text": { "type": "plain_text", @@ -243,7 +243,7 @@ def home( # pylint: disable=too-many-locals ] if bool(move_buttons["elements"]): - book_sections.append(move_buttons) # type: ignore + book_sections.append(move_buttons) else: book_sections.append( { @@ -276,7 +276,7 @@ def create_button(suggested_book_value: dict[str, Any]) -> dict[str, Any]: "value": f'{suggested_book_value["isbn"]}#{suggested_book_value["ml_model"]}', "action_id": "button_switch_action", }, - { # type: ignore + { "type": "button", "text": { "type": "plain_text", diff --git a/lambda/app/bee_slack_app/view/post_review.py b/lambda/app/bee_slack_app/view/post_review.py index d7a248bc..5804edca 100644 --- a/lambda/app/bee_slack_app/view/post_review.py +++ b/lambda/app/bee_slack_app/view/post_review.py @@ -200,16 +200,16 @@ def notify_review_post_message_blocks(review_contents: Review): { "type": "mrkdwn", "text": f"*投稿者*\n{review_contents['user_name']}", - }, # type:ignore + }, { "type": "mrkdwn", "text": f"*投稿日時*\n{update_datetime}", - }, # type:ignore - { # type:ignore + }, + { "type": "mrkdwn", "text": f"*自分にとっての評価*\n{review_contents['score_for_me']}", }, - { # type:ignore + { "type": "mrkdwn", "text": f"*永和社員へのおすすめ度*\n{review_contents['score_for_others']}", }, diff --git a/lambda/app/bee_slack_app/view/read_review.py b/lambda/app/bee_slack_app/view/read_review.py index 0a821ec6..c627696c 100644 --- a/lambda/app/bee_slack_app/view/read_review.py +++ b/lambda/app/bee_slack_app/view/read_review.py @@ -148,7 +148,7 @@ def review_of_user_modal( ] if bool(move_buttons["elements"]): - review_blocks.append(move_buttons) # type: ignore + review_blocks.append(move_buttons) view["blocks"].extend(review_blocks) # type: ignore @@ -210,16 +210,16 @@ def _review_sections( { "type": "mrkdwn", "text": f"*投稿者*\n{user_name}", - }, # type:ignore + }, { "type": "mrkdwn", "text": f"*投稿日時*\n{update_datetime}", - }, # type:ignore - { # type:ignore + }, + { "type": "mrkdwn", "text": f"*自分にとっての評価*\n{score_for_me}", }, - { # type:ignore + { "type": "mrkdwn", "text": f"*永和社員へのおすすめ度*\n{score_for_others}", }, @@ -227,7 +227,7 @@ def _review_sections( }, { "type": "section", - "text": { # type:ignore + "text": { "type": "mrkdwn", "text": f"*レビューコメント*\n\n{review_comment or '-'}", }, @@ -244,7 +244,7 @@ def _review_detail_button(*, user_id: str, isbn: str): return { "type": "actions", "elements": [ - { # type: ignore + { "type": "button", "text": { "type": "plain_text",