Merge pull request #447 from esminc/mypy-warn-unused-ignores

mypyの--warn-unused-ignoresを有効化
esminc · Feb 16, 2023 · 9bd4cc3 · 9bd4cc3
2 parents 2d5ce55 + 7ebb75f
commit 9bd4cc3
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/lambda/app/Makefile b/lambda/app/Makefile
@@ -24,7 +24,7 @@ lint-check:
 
 .PHONY: type-check
 type-check:
-	pipenv run mypy . --disallow-untyped-calls --disallow-any-generics --disallow-untyped-decorators
+	pipenv run mypy . --disallow-untyped-calls --disallow-any-generics --disallow-untyped-decorators --warn-unused-ignores
 
 .PHONY: test
 test: export AWS_DEFAULT_REGION := us-east-1

diff --git a/lambda/app/bee_slack_app/view/home.py b/lambda/app/bee_slack_app/view/home.py
@@ -127,7 +127,7 @@ def home(  # pylint: disable=too-many-locals
                 {
                     "type": "mrkdwn",
                     "text": f"*現在のレビュー投稿数 {total_review_count}件*",
-                },  # type:ignore
+                },
             ],
         },
         {
@@ -210,7 +210,7 @@ def home(  # pylint: disable=too-many-locals
                 {
                     "type": "actions",
                     "elements": [
-                        {  # type: ignore
+                        {
                             "type": "button",
                             "text": {
                                 "type": "plain_text",
@@ -243,7 +243,7 @@ def home(  # pylint: disable=too-many-locals
             ]
 
         if bool(move_buttons["elements"]):
-            book_sections.append(move_buttons)  # type: ignore
+            book_sections.append(move_buttons)
     else:
         book_sections.append(
             {
@@ -276,7 +276,7 @@ def create_button(suggested_book_value: dict[str, Any]) -> dict[str, Any]:
                 "value": f'{suggested_book_value["isbn"]}#{suggested_book_value["ml_model"]}',
                 "action_id": "button_switch_action",
             },
-            {  # type: ignore
+            {
                 "type": "button",
                 "text": {
                     "type": "plain_text",

diff --git a/lambda/app/bee_slack_app/view/post_review.py b/lambda/app/bee_slack_app/view/post_review.py
@@ -200,16 +200,16 @@ def notify_review_post_message_blocks(review_contents: Review):
                 {
                     "type": "mrkdwn",
                     "text": f"*投稿者*\n{review_contents['user_name']}",
-                },  # type:ignore
+                },
                 {
                     "type": "mrkdwn",
                     "text": f"*投稿日時*\n{update_datetime}",
-                },  # type:ignore
-                {  # type:ignore
+                },
+                {
                     "type": "mrkdwn",
                     "text": f"*自分にとっての評価*\n{review_contents['score_for_me']}",
                 },
-                {  # type:ignore
+                {
                     "type": "mrkdwn",
                     "text": f"*永和社員へのおすすめ度*\n{review_contents['score_for_others']}",
                 },

diff --git a/lambda/app/bee_slack_app/view/read_review.py b/lambda/app/bee_slack_app/view/read_review.py
@@ -148,7 +148,7 @@ def review_of_user_modal(
         ]
 
     if bool(move_buttons["elements"]):
-        review_blocks.append(move_buttons)  # type: ignore
+        review_blocks.append(move_buttons)
 
     view["blocks"].extend(review_blocks)  # type: ignore
 
@@ -210,24 +210,24 @@ def _review_sections(
                 {
                     "type": "mrkdwn",
                     "text": f"*投稿者*\n{user_name}",
-                },  # type:ignore
+                },
                 {
                     "type": "mrkdwn",
                     "text": f"*投稿日時*\n{update_datetime}",
-                },  # type:ignore
-                {  # type:ignore
+                },
+                {
                     "type": "mrkdwn",
                     "text": f"*自分にとっての評価*\n{score_for_me}",
                 },
-                {  # type:ignore
+                {
                     "type": "mrkdwn",
                     "text": f"*永和社員へのおすすめ度*\n{score_for_others}",
                 },
             ],
         },
         {
             "type": "section",
-            "text": {  # type:ignore
+            "text": {
                 "type": "mrkdwn",
                 "text": f"*レビューコメント*\n\n{review_comment or '-'}",
             },
@@ -244,7 +244,7 @@ def _review_detail_button(*, user_id: str, isbn: str):
     return {
         "type": "actions",
         "elements": [
-            {  # type: ignore
+            {
                 "type": "button",
                 "text": {
                     "type": "plain_text",