Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues #55

Open
5 tasks
erikh opened this issue Sep 30, 2023 · 3 comments
Open
5 tasks

Performance issues #55

erikh opened this issue Sep 30, 2023 · 3 comments
Milestone

Comments

@erikh
Copy link
Owner

erikh commented Sep 30, 2023

Gonna keep a running tally of perf issues to resolve. Most of this revolves around google calendar:

  • tokio/thread/sit function is very expensive; maybe some use of channels would help here.
  • use the refresh token properly, right now every invocation refreshes the token
  • in sui, we really don't need to update with google calendar on every action. just a periodic refresh would work, but because it's interlocked with the draw loop we don't get that functionality.
  • look for more opportunities to leverage references in heavy iterations of local state
  • use rustix for flock instead of libc
@erikh
Copy link
Owner Author

erikh commented Oct 2, 2023

The latest version of gcal has a debug mode which helped me isolate that we make a ton of http calls when resolving recurring tasks.

Just making notes here, I know some of the issues in my head, but it helps to have a reminder for some of them.

@erikh
Copy link
Owner Author

erikh commented Oct 2, 2023

I am also seeing i/o errors in the 0.4.x series chatting with gcal which causes sui to spin out of control.

@erikh
Copy link
Owner Author

erikh commented Oct 9, 2023

I've been looking into this and one of the things I threw in there out of desperation was a call to the fetch API during a record conversion routine, which is likely causing a N*N query (yes, really) and more or less bombing google calendar with requests. I've dumped some of this which gives me educated insight. I'm just not sure what the right solution is, and I've been preoccupied with other more pressing matters, so I'm writing this down so I don't forget.

@erikh erikh added this to the 0.5.0 milestone Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant