Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ASCII characters are not recognized by print_explicit_imports #83

Open
JoshuaLampert opened this issue Sep 25, 2024 · 0 comments
Open

Comments

@JoshuaLampert
Copy link

Let's say we have the following module in a file Foo.jl:

module Foo
using LinearAlgebra
bar(a, b) = a  b
end

where is exported from LinearAlgebra.jl. Running print_explicit_imports(Foo, "Foo.jl") gives

julia> print_explicit_imports(Foo, "Foo.jl")
  Module Main.Foo is relying on implicit imports for 1 name. This could be explicitly imported as follows:

  using LinearAlgebra: LinearAlgebra

However, exchanging using LinearAlgebra by the suggested using LinearAlgebra: LinearAlgebra breaks the module of course since is not available anymore. I would expect ExplicitImports.jl to suggest using LinearAlgebra: LinearAlgebra, ⋅. I have tested that the same happens with ×. So I assume this happens for non-ASCII characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant