Update races.xml #950
Open
Update races.xml #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: https://bugs.eressea.de/view.php?id=2786 Unnecessary decimal places removed
Tip error fixed. Aurareg at fairy is 1.5 not 1
ennorehling
reviewed
Dec 6, 2021
res/eressea/races.xml
Outdated
| @@ -202,7 +202,7 @@ | |||
| <skill name="taxation" modifier="-99"/> | |||
| <attack type="4" damage="1d4"/> | |||
| </race> | |||
| <race name="fairy" magres="80" maxaura="1" regaura="1" weight="200" capacity="540" speed="1" hp="6" damage="1d3" unarmedattack="0" unarmeddefense="0" attackmodifier="6" defensemodifier="14" fly="yes" walk="yes" teach="no" getitem="yes" equipment="yes"> | |||
There was a problem hiding this comment.
Die Dezimalstelle hier war doch nicht unnötig? 1.5 ist nicht das selbe wie 1, das ist also eine Regeländerung.
There was a problem hiding this comment.
Dazu habe ich doch selbst einen änderungsantrag gemacht um den tipfehler zu beheben, dachte ich ...
|
Ganz entfernen würde ich die Nachkommastellen nicht wollen. Es ist einfacher zu erkennen, dass eine Zahl Nachkommastellen haben kann, wenn da 1.0 steht und nicht 1. Und man sieht leichter, ob eine Chance in Prozenten (1 = 1%) oder als Chance (1.0 = 100%) angegeben werden soll. Dass es beide Varianten gibt, ist eine Altlast, die aber erst im Code beseitigt werden müsste. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://bugs.eressea.de/view.php?id=2786
Unnecessary decimal places removed