Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pull Request Template #260

Merged
merged 3 commits into from
Feb 3, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<!-- markdownlint-disable MD041 -->
<!-- Helper comments to guide you in filling the pull request.
Feel free to delete the comments when you are filling out the template, or leave them as they will not be visible.
If this is your first contribution: Consider reading CONTRIBUTING.md to understand the expectations of a pull-request. πŸ“ƒ
-->
### What have I made? πŸ‘©β€πŸ’»

<!-- REMINDER: The rvmsharp repo is Public! The Pull-Request MUST NOT contain any Equinor Internal information. -->

<!-- Short description of your feature / fix.
Example: Adds a faster way to parse RVM files, using a memory layout improvement for 10x better read performance. This will make parsing faster, and enable runtime parsing in client code.
-->

<!-- Link to the issue you are working on. The format is #GitHubIssueId OR AB#DevOpsBoardsId -->
Related to AB#

### How can you best review this? 🧐

<!-- A short description of how this should be reviewed, to help the reviewer better understand the code.
Example: This feature can be verified working as expected by observing the runtime lowered from 100 to 10 seconds on the Huldra Dataset.
I also need a code review. I have self-commented in the review with some areas I would like to discuss if I could do this differently.
-->

### [Optional] Screenshot or Profiling data 🀳 <!-- Adjust title, or remove this section if unused -->

<!-- Screenshots and gifs can be useful to understand how a feature should look or work.
Tip: Use `Windows-Shift-S` to take a quick screenshot, and press `Ctrl-V` to auto embed the image.
-->

### Did I remember everything checklist?
<!-- If any task is not applicable, just check it or strikethrough like this ~~This text will be strikethroughed~~ -->
<!-- If anything wont be checked, consider writing why in a sub-point
How to bulletpoints:
* [ ] I wrote some awesome code! 😎
* There is no code :(
-->

* [x] I made some awesome changes! 😎
* [ ] I left the code in a better state than when I started working on it. ✨
* [ ] I wrote unit and/or integration tests. πŸ‘Ύ
* [ ] I have considered any security implications, and requested review of them explicitly. πŸ”
* [ ] I verified that it checks the acceptance criteria. πŸ“œ
* [ ] I have tested this change in the Echo DEV environment, or requested someone to test it for me πŸš€
* [ ] I updated the documentation/readme. πŸ“š
* [ ] I made the PR title descriptive and human-readable πŸ‘¨β€πŸ‘©β€πŸ‘¦β€πŸ‘¦
* [ ] Existing unreported issues I found but could not fix was added as a new Issues 🚧

<!-- Metadata:
The most updated source of this template is found in https://github.com/equinor/Echo/blob/master/docs/github.md#pull-request-templates
-->