Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pull Request Template #260

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Add Pull Request Template #260

merged 3 commits into from
Feb 3, 2025

Conversation

Strepto
Copy link
Collaborator

@Strepto Strepto commented Jan 29, 2025

What have I made? πŸ‘©β€πŸ’»

Adds a new Pull Request Template to make the PRs more descriptive and work as documentation and a self-review checklist.

Related to AB#229261

How can you best review this? 🧐

Read the pull-request template and see if it makes sense. Give feedback on the checklist and the template, and suggest new points to check or points to remove.

Did I remember everything checklist?

  • I made some awesome changes! 😎
  • I left the code in a better state than when I started working on it. ✨
  • I wrote unit and/or integration tests. πŸ‘Ύ
  • I have considered any security implications, and requested review of them explicitly. πŸ”
  • I verified that it checks the acceptance criteria. πŸ“œ
  • I have tested this change in the Echo DEV environment, or requested someone to test it for me πŸš€
  • I updated the documentation/readme. πŸ“š
  • I made the PR title descriptive and human-readable πŸ‘¨β€πŸ‘©β€πŸ‘¦β€πŸ‘¦
  • Existing unreported issues I found but could not fix was added as a new Issues 🚧

@ArGr1 ArGr1 self-requested a review January 29, 2025 09:48
Copy link
Contributor

@ArGr1 ArGr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good πŸ‘

@Strepto Strepto merged commit 74141b3 into master Feb 3, 2025
9 checks passed
@Strepto Strepto deleted the nih/feat/pr-template branch February 3, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants