Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Mappings #994

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

mferrera
Copy link
Collaborator

From discussion 11 Feb 2025

@perolavsvendsen
Copy link
Member

perolavsvendsen commented Feb 11, 2025

Summary of the attempted point on changing the current workflow around data.name and SMDA-linking.

Concepts:

  • "FMU name": The name used inside FMU (also de-facto an identifier)
  • "SMDA name": The name used in SMDA (also de-facto an identifier in combination with the strat column)

Today:

  • General rule: data.name is the "FMU name" when exported
  • Exception: When data.name is referring to an instance which is also defined in the master data:
    • data.name is changed to the SMDA name.
    • data.is_stratigraphic is set to True.
    • The FMU name is appended to the list of alias.

The end result of this is that, for data objects that are instances of an entity defined in master data, the data.name equals the master data name - which is the identifier.

This is stuff we have inherited from the definitions of metadata made before fmu-dataio became a thing.

Confusing much?

Possible better solution to this:

  • All data objects are exported with their "FMU name". No exceptions.
  • For data objects which are instances of some entity defined in master data (stratigraphy, well, etc), we add reference in the metadata, something like:
data:
  name: <FMU name, unchanged>
masterdata:
  smda:
    field: ...
    country: ...
    something: # <--
      name: ...
      uuid: ...
      whatever: ...
  • The presence of this is the equivalent of the current data.is_stratigraphic

(This may be a derailing of the mapping discussion, but feels like fixing this would make it easier to do mapping back and forth.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants