Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Updated notebook to use more recent package versions #11

Merged
merged 6 commits into from
Jun 9, 2022

Conversation

erlendviggen
Copy link
Contributor

The notebook was written for dlisio 0.1.16, and major changes have occurred since then. This branch updates the notebook to the most recent version of dlisio, 0.3.6. It also updates the rest of the packages in requirements.txt to more modern versions, which I chose as the most recent versions available in the Anaconda repository (which might not be quite as up-to-date as e.g. pip).

Changelog

  • Updated package versions in requirements.txt, including bumping dlisio to the newest version
  • Added units to the parameter table using the temporary interface for parameter units (resolves Show units for the parameters #7)
  • Fixed broken references to the dlisio documentation from before it was reworked
  • Compensated for LogicalFile.match() having been removed
  • Compensated for changed behaviour of LogicalFile.object(); object type must now be uppercase
    • Regular expressions in object names do not seem to be supported anymore, but they were never that essential here in the first place.
  • Fixed bug in waveform_cross_section() due to changes in matplotlib pcolormesh()

TODO

There are still a few small things to do before we merge this pull request:

  • Access to the Azure blob of the log file is broken, and needs to be fixed; I need some help for this one
  • I committed a stripped notebook so that we can easily diff changes, and we should commit the notebook with output when we are done

…raded to the newest versions that are available in the Anaconda repository. Upgraded to Python 3.9.12 as well.
* Changed to the new dlis interface of dlisio
* Added units to parameters using the lower-level interface in dlisio
* Fixed broken references to the dlisio documentation from before it was reworked
* Compensated for LogicalFile.match() having been removed
* Compensated for changed behaviour of LogicalFile.object(); object type must now be uppercase
	* Regular expressions in object names do not seem to be supported anymore, but they were never that essential here in the first place
* Fixed bug in waveform_cross_section() due to changes in matplotlib pcolormesh()
@erlendviggen erlendviggen requested a review from ErlendHaa June 8, 2022 10:34
Copy link
Contributor

@ErlendHaa ErlendHaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

acoustic.ipynb Outdated Show resolved Hide resolved
acoustic.ipynb Outdated Show resolved Hide resolved
acoustic.ipynb Outdated Show resolved Hide resolved
acoustic.ipynb Outdated Show resolved Hide resolved
@erlendviggen erlendviggen merged commit 7cdd4f1 into master Jun 9, 2022
@erlendviggen erlendviggen deleted the version-update branch June 9, 2022 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show units for the parameters
2 participants