Simplify GitHub Actions #18
Conversation
| @@ -8,6 +8,10 @@ env: | |||
| REGISTRY: ghcr.io | |||
| IMAGE_NAME: ${{ github.repository }} | |||
|
|
|||
| concurrency: | |||
There was a problem hiding this comment.
ah this is awesome - thanks
| @@ -55,34 +55,10 @@ jobs: | |||
| rmarkdown::render("writeup/si.Rmd", output_dir = "docs") | |||
| shell: Rscript {0} | |||
|
|
|||
| - name: Upload documentation | |||
| uses: actions/upload-artifact@v2 | |||
| - name: Deploy to GitHub pages 🚀 | |||
There was a problem hiding this comment.
This is obviously much cleaner but the bit it loses is the ability to inspect docs etc generated by branches other than main which is quite nice when making edits. Is there a way to do that with this action?
There was a problem hiding this comment.
Oh right, missed this. As it is, it would redeploy on pushes to any branch, which is probably not what you want.
I would test things locally. I'm not sure there is a huge benefit to do it via GitHub Actions. Am I missing something?
There was a problem hiding this comment.
Mostly that I don't want to test things locally 😆
Also very handy for collabs etc where they may not have the dev environment and/or may not post what the updated text looks like.
Bisaloo
force-pushed
the
simplify-actions
branch
from
1cc4beb to
385514f
Compare
|
Best I can do is this then 🤷 |
No description provided.