Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set use_c=True by default for KNNClassifier/KNNRegressor #263

Merged
merged 2 commits into from
Dec 30, 2024
Merged

feat: set use_c=True by default for KNNClassifier/KNNRegressor #263

merged 2 commits into from
Dec 30, 2024

Conversation

eonu
Copy link
Owner

@eonu eonu commented Dec 30, 2024

Description

Set use_c=True by default for KNNClassifier/KNNRegressor.

Checklist

  • I have added new tests (if necessary).
  • I have ensured that tests and coverage are passing on CI.
  • I have updated any relevant documentation (if necessary).
  • I have used a descriptive pull request title.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1d1a847d-627b-4bf6-91d6-7ea1bb9c0237

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 82.519%
Files with Coverage Reduction New Missed Lines %
_internal/_validation.py 1 65.32%
Totals Coverage Status
Change from base Build 55f43270-89cd-4fa7-9dc7-f053ceef0a48: -0.07%
Covered Lines: 1166
Relevant Lines: 1413
💛 - Coveralls

@eonu eonu merged commit cb9c21d into dev Dec 30, 2024
11 checks passed
@eonu eonu deleted the set_use_c_true branch December 30, 2024 13:23
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eonu @coveralls