Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add model spec support to HMMClassifier.__init__ #258

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

eonu
Copy link
Owner

@eonu eonu commented Dec 27, 2024

Add model spec support to HMMClassifier.__init__

  • Adds the ability to specify a HMM variant and configuration in HMMClassifier.__init__.
  • This enables the use of sequentia.model_selection on HMMClassifier objects.

Checklist

  • I have added new tests (if necessary).
  • I have ensured that tests and coverage are passing on CI.
  • I have updated any relevant documentation (if necessary).
  • I have used a descriptive pull request title.

@coveralls
Copy link

Pull Request Test Coverage Report for Build b4893f34-0087-4d48-afbd-b35b1e6c834c

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 82.59%

Files with Coverage Reduction New Missed Lines %
model_selection/_search.py 9 89.02%
models/hmm/classifier.py 11 91.13%
Totals Coverage Status
Change from base Build 04ffbfc8-bf8b-4118-813f-30993dc79387: 0.1%
Covered Lines: 1167
Relevant Lines: 1413

💛 - Coveralls

@eonu eonu merged commit 4ce8f9e into dev Dec 27, 2024
12 checks passed
@eonu eonu deleted the add_hmm_spec_to_classifier_init branch December 27, 2024 20:38
This was referenced Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants