api: add per_host_thresholds in CircuitBreakers #5211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5211 +/- ##
==========================================
+ Coverage 66.87% 66.92% +0.05%
==========================================
Files 210 210
Lines 32998 32998
==========================================
+ Hits 22067 22084 +17
+ Misses 9592 9577 -15
+ Partials 1339 1337 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
jukie
force-pushed
the
api/per-host-circuit-breaker-thresholds
branch
from
758a1f3 to
6a2a6f3
Compare
jukie
commented
Feb 5, 2025
| // Defines per-host Circuit Breaker thresholds | ||
| // +optional | ||
| // +notImplementedHide | ||
| PerHostThresholds *PerHostCircuitBreakers `json:"perHostThresholds,omitempty"` |
There was a problem hiding this comment.
Should this be a separate field or something like maxConnectionsPerHost since that's the only field currently supported. In the future could add maxParallelRequestsPerHost, etc as more support is added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for configuring per-host circuit breaker limits
Which issue(s) this PR fixes:
Fixes #5210
Release Notes: No