Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add client packages #5206

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

dprotaso
Copy link

@dprotaso dprotaso commented Feb 5, 2025

Commits

  • git add tools for generating clientset, informers, and listers
  • drop manual registration and annotate k8s crds types
  • add make targets to generate clients
  • wire client gen into make generate call
  • annotate EnvoyGateway

What type of PR is this?

  • "feat(client): add new feature"

What this PR does / why we need it:
This adds client sets allowing end-users to create envoy gateway resources programmatically.

Which issue(s) this PR fixes:

Fixes None

Release Notes: No

@dprotaso dprotaso requested a review from a team as a code owner February 5, 2025 04:10
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 696 lines in your changes missing coverage. Please review.

Project coverage is 65.43%. Comparing base (d50be42) to head (7b2200c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/informers/externalversions/factory.go 0.00% 102 Missing ⚠️
...ientset/versioned/typed/api/v1alpha1/api_client.go 0.00% 58 Missing ⚠️
pkg/clientset/versioned/clientset.go 0.00% 47 Missing ⚠️
...kg/clientset/versioned/fake/clientset_generated.go 0.00% 23 Missing ⚠️
pkg/informers/externalversions/generic.go 0.00% 23 Missing ⚠️
...informers/externalversions/api/v1alpha1/backend.go 0.00% 21 Missing ⚠️
...ernalversions/api/v1alpha1/backendtrafficpolicy.go 0.00% 21 Missing ⚠️
...ternalversions/api/v1alpha1/clienttrafficpolicy.go 0.00% 21 Missing ⚠️
...ernalversions/api/v1alpha1/envoyextensionpolicy.go 0.00% 21 Missing ⚠️
.../externalversions/api/v1alpha1/envoypatchpolicy.go 0.00% 21 Missing ⚠️
... and 32 more

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5206      +/-   ##
==========================================
- Coverage   66.88%   65.43%   -1.45%     
==========================================
  Files         210      243      +33     
  Lines       32998    33676     +678     
==========================================
- Hits        22070    22037      -33     
- Misses       9589    10296     +707     
- Partials     1339     1343       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant