Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: use a dedicated listener port for envoy proxy readiness #5197

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

xds: use a dedicated listener port for envoy proxy readiness #5197

wants to merge 3 commits into from
+3,265 −720

Conversation

zirain
Copy link
Member

@zirain zirain commented Feb 4, 2025

fixes: #5144

@zirain zirain requested a review from a team as a code owner February 4, 2025 09:47
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.91%. Comparing base (54ca51b) to head (a7c940d).

Files with missing lines Patch % Lines
internal/gatewayapi/listener.go 68.42% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5197      +/-   ##
==========================================
+ Coverage   66.87%   66.91%   +0.04%     
==========================================
  Files         210      211       +1     
  Lines       32998    33140     +142     
==========================================
+ Hits        22067    22176     +109     
- Misses       9590     9619      +29     
- Partials     1341     1345       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zirain added 2 commits February 4, 2025 20:29
@zirain
build ready listener
8ff01d0 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
release-notes
99121f3 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the readiness-listener branch from 70e151d to 99121f3 Compare February 4, 2025 12:32
@zirain
fix gen
a7c940d 
Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a dedicated listener port for envoy proxy readiness
1 participant
@zirain