Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run go mod tidy + and drop go.mod|sum files under site/ #5191

Closed
wants to merge 1 commit into from

Conversation

dprotaso
Copy link

@dprotaso dprotaso commented Feb 3, 2025

Part of: #5188

  1. Ran find . -name "go.mod" -exec bash -c 'cd $(dirname {}); go mod tidy' \;
  2. Removed site/ go.* files since there isn't any child go files under that directory tree

@dprotaso dprotaso requested a review from a team as a code owner February 3, 2025 02:26
@dprotaso dprotaso force-pushed the fix-controller-gen-go-sum branch from 7054e27 to 43be1d1 Compare February 3, 2025 02:26
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
@dprotaso dprotaso force-pushed the fix-controller-gen-go-sum branch from 43be1d1 to f47b734 Compare February 3, 2025 02:29
@zirain
Copy link
Member

zirain commented Feb 3, 2025

find . -name "go.mod" -exec bash -c 'cd $(dirname {}); go mod tidy' \;
this can be part of make go.mod.lint

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.90%. Comparing base (fcc458a) to head (f47b734).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5191      +/-   ##
==========================================
+ Coverage   66.88%   66.90%   +0.01%     
==========================================
  Files         210      210              
  Lines       32998    32998              
==========================================
+ Hits        22070    22076       +6     
+ Misses       9589     9584       -5     
+ Partials     1339     1338       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Author

dprotaso commented Feb 4, 2025

Closing in favour of #5199

@dprotaso dprotaso closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants