-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(healthz-server): add option to customize port #5151
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Hi @shawnh2! Can you please run the workflows for this PR and review it whenever possible? Thanks. |
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Hi! Is there something required from my end for the review of this PR? |
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, code overall LGTM
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5151 +/- ##
==========================================
+ Coverage 66.85% 66.87% +0.01%
==========================================
Files 210 210
Lines 32998 33003 +5
==========================================
+ Hits 22061 22070 +9
+ Misses 9595 9593 -2
+ Partials 1342 1340 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
@shawnh2 The build seems to have failed due to a network error while installing the dependencies for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
what about kubernetes provider? |
discussed in #5151 (comment), leave it until we have any user requests |
then we need to highlight in api. |
What type of PR is this?
Adds option to customize the port for the healthz server, while maintaining the default one to be 8081.
What this PR does / why we need it:
The same port for the health server causes port conflicts in parallel test runs.
Which issue(s) this PR fixes:
Fixes #5149
Release Notes: Yes