Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(healthz-server): add option to customize port #5151

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

EshaanAgg
Copy link

@EshaanAgg EshaanAgg commented Jan 25, 2025

What type of PR is this?
Adds option to customize the port for the healthz server, while maintaining the default one to be 8081.

What this PR does / why we need it:
The same port for the health server causes port conflicts in parallel test runs.

Which issue(s) this PR fixes:
Fixes #5149

Release Notes: Yes

new features: |
    Added support to configure the Healthz Probe server port in FileProvider API & KubernetesProvider API.

Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
@EshaanAgg EshaanAgg requested a review from a team as a code owner January 25, 2025 06:30
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
@EshaanAgg
Copy link
Author

Hi @shawnh2! Can you please run the workflows for this PR and review it whenever possible? Thanks.

Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
@EshaanAgg
Copy link
Author

Hi! Is there something required from my end for the review of this PR?

@EshaanAgg EshaanAgg requested a review from shawnh2 February 3, 2025 19:24
internal/provider/file/file_test.go Outdated Show resolved Hide resolved
internal/provider/file/file.go Show resolved Hide resolved
internal/provider/file/file.go Outdated Show resolved Hide resolved
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
@EshaanAgg EshaanAgg requested a review from shawnh2 February 5, 2025 17:55
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, code overall LGTM

internal/provider/file/file.go Outdated Show resolved Hide resolved
api/v1alpha1/envoygateway_types.go Outdated Show resolved Hide resolved
Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
@EshaanAgg EshaanAgg requested a review from shawnh2 February 6, 2025 07:45
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.87%. Comparing base (48459d4) to head (b7b67f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5151      +/-   ##
==========================================
+ Coverage   66.85%   66.87%   +0.01%     
==========================================
  Files         210      210              
  Lines       32998    33003       +5     
==========================================
+ Hits        22061    22070       +9     
+ Misses       9595     9593       -2     
+ Partials     1342     1340       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
@EshaanAgg
Copy link
Author

@shawnh2 The build seems to have failed due to a network error while installing the dependencies for the build action and not due to any code changes. Can you please re-run that workflow?

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@shawnh2 shawnh2 requested review from a team February 6, 2025 11:54
@zirain
Copy link
Member

zirain commented Feb 6, 2025

what about kubernetes provider?

@shawnh2
Copy link
Contributor

shawnh2 commented Feb 6, 2025

what about kubernetes provider?

discussed in #5151 (comment), leave it until we have any user requests

@zirain
Copy link
Member

zirain commented Feb 7, 2025

then we need to highlight in api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make healthz server port in file-provider configurable
3 participants