Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gateway http listener isolation #4000

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

levikobi
Copy link
Contributor

@levikobi levikobi commented Aug 5, 2024

What type of PR is this?

feat(gateway-api): add support for gateway HTTP listener isolation.

What this PR does / why we need it:

  • Adds support for gateway HTTP listener isolation.
  • Enables GatewayHTTPListenerIsolation conformance test

Which issue(s) this PR fixes:

Fixes #3352

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.61%. Comparing base (eac30d6) to head (fb8a091).
Report is 17 commits behind head on main.

Files Patch % Lines
internal/gatewayapi/helpers.go 90.90% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4000      +/-   ##
==========================================
+ Coverage   67.59%   67.61%   +0.01%     
==========================================
  Files         186      186              
  Lines       22767    22783      +16     
==========================================
+ Hits        15390    15404      +14     
- Misses       6272     6273       +1     
- Partials     1105     1106       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levikobi levikobi force-pushed the gateway-http-listener-isolation branch from 0423c56 to 3411821 Compare August 5, 2024 05:10
@levikobi levikobi force-pushed the gateway-http-listener-isolation branch from 3411821 to 8069bd4 Compare August 13, 2024 04:32
@levikobi levikobi marked this pull request as ready for review August 13, 2024 04:33
@levikobi levikobi requested a review from a team as a code owner August 13, 2024 04:33
@levikobi levikobi requested a review from arkodg August 13, 2024 04:37
Signed-off-by: Kobi Levi <kobilevi503@gmail.com>
@levikobi levikobi force-pushed the gateway-http-listener-isolation branch from 8069bd4 to fb8a091 Compare August 13, 2024 04:40
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team August 13, 2024 18:41
@arkodg arkodg added this to the v1.2.0-rc1 milestone Aug 13, 2024
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkodg arkodg merged commit 97830e9 into envoyproxy:main Aug 15, 2024
23 of 24 checks passed
arkodg pushed a commit to arkodg/gateway that referenced this pull request Sep 7, 2024
Signed-off-by: Kobi Levi <kobilevi503@gmail.com>
(cherry picked from commit 97830e9)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg pushed a commit to arkodg/gateway that referenced this pull request Sep 7, 2024
Signed-off-by: Kobi Levi <kobilevi503@gmail.com>
(cherry picked from commit 97830e9)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
guydc pushed a commit that referenced this pull request Sep 10, 2024
* bugfix: fix upstream get unwanted /. (#3990)

* bugfix: fix upstream get unwanted /.

Signed-off-by: qicz <qiczzhu@gmail.com>

* ut for bugfix

Signed-off-by: qicz <qiczzhu@gmail.com>

---------

Signed-off-by: qicz <qiczzhu@gmail.com>
Co-authored-by: Xunzhuo <bitliu@tencent.com>
(cherry picked from commit b77f6a4)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* feat: gateway http listener isolation (#4000)

Signed-off-by: Kobi Levi <kobilevi503@gmail.com>
(cherry picked from commit 97830e9)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: multiple reference grants in same namespace (#4008)

* fix: multiple reference grants in same namespace

Signed-off-by: Ardika Bagus <me@ardikabs.com>

* test: add e2e test

Signed-off-by: Ardika Bagus <me@ardikabs.com>

* chore: wrong service port

Signed-off-by: Ardika Bagus <me@ardikabs.com>

---------

Signed-off-by: Ardika Bagus <me@ardikabs.com>
(cherry picked from commit b82f4b2)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* reduce readinessProbe failureThreshold and periodSeconds (#4021)

* Reduces time for the endpoint to be removed from the endpointSlice
from `30s` (3 * 10) to `5s` (1 * 5)

* Since kube-proxy and CNIs rely on this info and so do external LBs
like GKE https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 67575b8)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: add header values as described in the documentation (#4031)

Add header values after splitting the provided value string on ',', like
described in the documentation.

Signed-off-by: Lior Okman <lior.okman@sap.com>
(cherry picked from commit eac30d6)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix ratelimit statsd not working (#4073)

fix ratelimit statd not working

Signed-off-by: zirain <zirain2009@gmail.com>
(cherry picked from commit 6ab6482)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: active http healthcheck documents a default for expected status, but doesn't use it (#4090)

If no expected status was explicitly set, use the default value as
described in the documentation.

Signed-off-by: Lior Okman <lior.okman@sap.com>
(cherry picked from commit 0926b38)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* Fix IsNotFound check for secret and configmap (#4126)

fix IsNotFound check for secret and configmap

Signed-off-by: TasdidurRahman <tasdid@appscode.com>
(cherry picked from commit c20315f)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix: assign sugar logger name. (#4144)

Signed-off-by: qicz <qiczzhu@gmail.com>
Co-authored-by: zirain <zirain2009@gmail.com>
(cherry picked from commit b50f5fa)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* use sets and return stable result (#4074)

Signed-off-by: zirain <zirain2009@gmail.com>
(cherry picked from commit 6066f5a)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* delete internal/gatewayapi/clustersettings.go NA for v1.1

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* bump to go1.22.7 (#4175)

* bump to go1.22.6

Signed-off-by: zirain <zirain2009@gmail.com>

* bump to 1.22.7

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
(cherry picked from commit 69bf882)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: qicz <qiczzhu@gmail.com>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Kobi Levi <kobilevi503@gmail.com>
Signed-off-by: Ardika Bagus <me@ardikabs.com>
Signed-off-by: Lior Okman <lior.okman@sap.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: TasdidurRahman <tasdid@appscode.com>
Co-authored-by: qi <qiczzhu@gmail.com>
Co-authored-by: Xunzhuo <bitliu@tencent.com>
Co-authored-by: Kobi Levi <56400138+levikobi@users.noreply.github.com>
Co-authored-by: Ardika <me@ardikabs.com>
Co-authored-by: Lior Okman <lior.okman@sap.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Co-authored-by: Tasdidur Rahman <52253951+TasdidurRahman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable GatewayHTTPListenerIsolation conformance test
3 participants