feat(translator): prefix TCP FilterChain name by irListener name

[aoledk]

What this PR does / why we need it:

Prefix TCP FilterChain name by irListener name, to let extension server can locate TCP FilterChain according to policy's targetRef(s).

xref #3461 (comment)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.91%. Comparing base (8be7e69) to head (562df20).
Report is 105 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3738      +/-   ##
==========================================
+ Coverage   67.89%   67.91%   +0.02%     
==========================================
  Files         187      187              
  Lines       23022    23022              
==========================================
+ Hits        15630    15635       +5     
+ Misses       6278     6273       -5     
  Partials     1114     1114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zhaohuabing]

No strong opinion on the filterchain name, but I think extension server should not make assumption on the structure of the filterchain name or any other names in the xDS. For example, assume the filterchain name will be in the form of "gateway name/listener name/routetype/route name".

This is just an implementation detail of the xDS translation. It's not part of the EG API. There's no guarantee that it won't change over time.

For EnvoyPatchPolicy, it's ok to use these names to find a specified field in the generated xDS, since it's made clear in the EG docs that EnvoyPatchPolicy' is unstable and the outcome may change across versions.

[aoledk]

No strong opinion on the filterchain name, but I think extension server should not make assumption on the structure of the filterchain name or any other names in the xDS. For example, assume the filterchain name will be in the form of "gateway name/listener name/routetype/route name".

This is just an implementation detail of the xDS translation. It's not part of the EG API. There's no guarantee that it won't change over time.

For EnvoyPatchPolicy, it's ok to use these names to find a specified field in the generated xDS, since it's made clear in the EG docs that EnvoyPatchPolicy' is unstable and the outcome may change across versions.

You are correct, this proposal has coupled EG with Extension Server on very unreliable contracts. Perhaps we need to brainstorm other solutions to let Extension Server can detect which FilterChain should be targeted by policies.

Here is a new proposal by @modatwork #3461 (comment)

[modatwork]

This is just an implementation detail of the xDS translation. It's not part of the EG API. There's no guarantee that it won't change over time.

+1.

However, there is currently no stable method for the extension server to manage the SectionName within the policy API. Can we include this PR in the next release? It’s significant for extensibility.

[zhaohuabing]

LGTM with the caveat that FilterChain name is not a contract for extension severs.

[arkodg]

can you instead update the IR name

gateway/internal/gatewayapi/helpers.go

Line 387 in 04c5ce2

func irTCPRouteName(route RouteContext) string {

?

[aoledk]

can you instead update the IR name

gateway/internal/gatewayapi/helpers.go

Line 387 in 04c5ce2

func irTCPRouteName(route RouteContext) string {

?

Sure, I can do this since each new ir.TCPRoute or ir.UDPRoute is being attached to unique irListener.

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!