Skip to content

Commit

Permalink
fix respect dnsTTL setting
Browse files Browse the repository at this point in the history
Signed-off-by: Alexander Volchok <alex.volchok@sap.com>
  • Loading branch information
alexwo committed Aug 1, 2024
1 parent e62acc7 commit bf83d06
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions internal/xds/translator/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@ func buildXdsCluster(args *xdsClusterArgs) *clusterv3.Cluster {
if args.dns.DNSRefreshRate.Duration > 0 {
cluster.DnsRefreshRate = durationpb.New(args.dns.DNSRefreshRate.Duration)

Check warning on line 151 in internal/xds/translator/cluster.go

View check run for this annotation

Codecov / codecov/patch

internal/xds/translator/cluster.go#L149-L151

Added lines #L149 - L151 were not covered by tests
}
if args.dns.RespectDNSTTL != nil {
cluster.RespectDnsTtl = ptr.Deref(args.dns.RespectDNSTTL, true)
}
}
if args.dns.RespectDNSTTL != nil {
cluster.RespectDnsTtl = ptr.Deref(args.dns.RespectDNSTTL, true)

Check warning on line 155 in internal/xds/translator/cluster.go

View check run for this annotation

Codecov / codecov/patch

internal/xds/translator/cluster.go#L154-L155

Added lines #L154 - L155 were not covered by tests
}
}
}
Expand Down

0 comments on commit bf83d06

Please sign in to comment.