Merge pull request #145 from enter-at/fix/http-handler/handle-none-bo…

…dy-values-gracefully fix(HTTPHandler): do not parse body if value is None
enter-at · Nov 5, 2020 · 6f3d7c0 · 6f3d7c0
2 parents 35b4481 + bd4402b
commit 6f3d7c0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lambda_handlers/handlers/http_handler.py b/lambda_handlers/handlers/http_handler.py
@@ -54,7 +54,7 @@ def on_exception(self, exception):
 
     def format_input(self, event):
         """Return `event` with a formatted `event['body']`."""
-        if 'body' in event:
+        if 'body' in event and event['body']:
             try:
                 event['body'] = self._input_format.format(event['body'])
             except FormatError as error:

diff --git a/lambda_handlers/handlers/tests/test_http_handler.py b/lambda_handlers/handlers/tests/test_http_handler.py
@@ -20,6 +20,11 @@ def test_empty_body_validation(self, handler):
         assert isinstance(response, dict)
         assert response['statusCode'] == 200
 
+    def test_none_body_validation(self, handler):
+        response = handler({'body': None}, None)
+        assert isinstance(response, dict)
+        assert response['statusCode'] == 200
+
     def test_invalid_body_validation(self, handler):
         response = handler({'body': '{.x'}, None)
         assert isinstance(response, dict)