[web] Deploy cast #703
Merged
[web] Deploy cast #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the web deployment process for the new monorepo. This is currently untested, I'll try to a do a preview deployment next of the accounts or cast app (since they're not yet on production).
## Description ## Tests
## Description ## Tests
Purposely opening this PR against a known bad state to verify that the check catches this issue.
Documentation only change.
We still need to provide at least the major version, and we'll need to remember to update these links when the major version changes. Ref: - https://docs.github.com/en/repositories/releasing-projects-on-github/searching-a-repositorys-releases
Note that the three dot syntax is needed, the two dot compare doesn't open a pull request. Ref: - https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/using-query-parameters-to-create-a-pull-request - https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-comparing-branches-in-pull-requests#three-dot-and-two-dot-git-diff-comparisons
There needs to be a better way, but this unblocks our current deployment
- Update the URLs for opening new deployment PRs - Include translations
@ua741 We still need to provide at least the major version, and we'll need to remember to update these links when the major version changes. Ref: - https://docs.github.com/en/repositories/releasing-projects-on-github/searching-a-repositorys-releases
…ks (#698) ## Tested by Purposely opening this PR against a known bad state to verify that the check catches this issue. And it worked. <img width="590" alt="Screenshot 2024-03-06 at 14 04 40" src="https://github.com/ente-io/ente/assets/24503581/e67bac5c-4191-4497-a771-b73f7c850379"> Have now rebased the PR of main, to also check that the verification succeeds in a known good state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy cast.ente.io