Skip to content

Commit

Permalink
export CGO_ENABLED=0
Browse files Browse the repository at this point in the history
The configuration used by goreleaser (which we previously used to build the
release binaries) had set CGO_ENABLED=0. Since we don't specifically need this
to be on, revert to that configuration.

Also add a few more go build flags to reduce the size of the produced binaries

Ref:
- wangyoucao577/go-release-action#33
- https://github.com/wangyoucao577/go-release-action
- https://github.com/ente-io/cli/blob/main/.goreleaser.yaml#L18

Related:
- #727
  • Loading branch information
mnvr committed Mar 7, 2024
1 parent b70ca6b commit 2101d06
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/cli-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,8 @@ jobs:
release_name: ${{ github.ref_name }}
goversion: "1.20"
project_path: "./cli"
pre_command: export CGO_ENABLED=0
build_flags: "-trimpath"
ldflags: "-s -w"
md5sum: false
sha256sum: true
3 changes: 2 additions & 1 deletion cli/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ OS_TARGETS=("windows" "linux" "darwin")
# Corresponding architectures for each OS
ARCH_TARGETS=("386 amd64" "386 amd64 arm arm64" "amd64 arm64")

export CGO_ENABLED=0
# Loop through each OS target
for index in "${!OS_TARGETS[@]}"
do
Expand All @@ -28,7 +29,7 @@ do
fi

# Build the binary and place it in the "bin" directory
go build -o "bin/$BINARY_NAME" main.go
go build -ldflags="-s -w" -trimpath -o "bin/$BINARY_NAME" main.go

# Print a message indicating the build is complete for the current OS and architecture
echo "Built for $OS ($ARCH) as bin/$BINARY_NAME"
Expand Down

0 comments on commit 2101d06

Please sign in to comment.