Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ws-max-queue parameter #2033

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

ssproessig-thales
Copy link
Contributor

allows configuring implementation detail of "websocket": maximum length of the queue that holds incoming messages

Summary

draft implementation for #2032

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex
Copy link
Sponsor Member

Kludex commented Jul 8, 2023

Anything else missing here?

@Kludex Kludex changed the title adds "ws-max-queue" config parameter Add --ws-max-queue parameter Jul 9, 2023
uvicorn/main.py Outdated Show resolved Hide resolved
docs/settings.md Outdated Show resolved Hide resolved
@ssproessig-thales ssproessig-thales marked this pull request as ready for review July 10, 2023 12:41
@Kludex
Copy link
Sponsor Member

Kludex commented Jul 10, 2023

Can you run ./scripts/lint, please?

@Kludex
Copy link
Sponsor Member

Kludex commented Jul 10, 2023

Thanks @ssproessig-thales 🙏

ssproessig-thales and others added 4 commits July 10, 2023 18:10
allows configuring implementation detail of "websocket": maximum length of the queue that holds incoming messages
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@Kludex Kludex force-pushed the add_ws_max_queue_to_config branch from f8bb0b5 to 0ded834 Compare July 10, 2023 16:11
@Kludex Kludex merged commit 57c6d57 into encode:master Jul 10, 2023
12 checks passed
@ssproessig-thales ssproessig-thales deleted the add_ws_max_queue_to_config branch July 10, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants