Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default PID Denom 2 for F411 #994

Merged
merged 2 commits into from
Apr 2, 2024
Merged

default PID Denom 2 for F411 #994

merged 2 commits into from
Apr 2, 2024

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Mar 28, 2024 •
edited
Loading

@nerdCopter
Copy link
Member Author

@Quick-Flash , @BeauBrewski what do you think about this quick-fix for F411 denom?

@nerdCopter
Copy link
Member Author

  • tested on CRAZYBEEF4DX (F411) resulted denom 2 and dshot300
  • tested SKYSTARSF405-AIO resulted denom 1 and dshot600
  • tested PYDRODRONEF7 resulted denom 1 and dshot600
  • tested HELIOSPRING resulted denom 1 and dshot600

@Quick-Flash
Copy link
Member

No need for dshot 300 as a default. If hardware is setup poorly and but any dshot is required it'll run slower than dshot600 as well. So 600 is a better default imo.

@nerdCopter
Copy link
Member Author

nerdCopter commented Mar 28, 2024 •
edited
Loading

okay, thanks, reverted mixer.c.

@nerdCopter nerdCopter changed the title default PID Denom 2 and DSHOT300 for F411 default PID Denom 2 for F411 Mar 28, 2024
@nerdCopter nerdCopter merged commit 1259124 into emuflight:master Apr 2, 2024
6 checks passed
@nerdCopter nerdCopter deleted the 20240328_modern_pid_denom branch April 2, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quick-Flash Quick-Flash Awaiting requested review from Quick-Flash

@BeauBrewski BeauBrewski Awaiting requested review from BeauBrewski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F411 are often 100% cpu
2 participants
@nerdCopter @Quick-Flash