buffer stream signals #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhuyan
force-pushed
the
dev/william/buffer-stream-signals
branch
from
25871a9
to
d100ce6
Compare
Pull Request Test Coverage Report for Build 9207770123Details
💛 - Coveralls |
qzhuyan
force-pushed
the
dev/william/buffer-stream-signals
branch
from
d100ce6
to
09c3d0c
Compare
qzhuyan
commented
May 23, 2024
qzhuyan
force-pushed
the
dev/william/buffer-stream-signals
branch
from
09c3d0c
to
d24a795
Compare
qzhuyan
force-pushed
the
dev/william/buffer-stream-signals
branch
from
d24a795
to
a2a9aa9
Compare
thalesmg
approved these changes
May 23, 2024
There was a problem hiding this comment.
Might need a copyright header in this file.
| ), | ||
| ok = quicer:controlling_process(S, self()), | ||
| {ok, NewOwner} = quicer:get_stream_owner(S), | ||
| NewOwner = self(), |
There was a problem hiding this comment.
Q: isn't the owner self() in the first place, so that controlling_process doesn't change?
There was a problem hiding this comment.
quicer:controlling_process will not skip owner change even when old owner is the new owner.
The point in this test is quicer_nif:mock_buffer_sig(S, Pid, {Ref, Term}) simulates the {Ref, Term} is supposed to be sent to the Pid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QUIC stream data is ensured ordered and lossless during stream handoff from old owner process to the new owner process.
This PR makes QUIC stream signals also ordered so that old owner does not need to take care of the
inflightmessages during the handoff.The new
quicer_owner_queuethings could be reused to later implement the sig queues for the quic connections.