Add insertion_order and color_conflict_handling to Legend
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emilk maybe include this in egui_plot 0.31.0 ? |
lucasmerlin
approved these changes
Feb 5, 2025
| @@ -198,17 +230,31 @@ impl LegendWidget { | |||
|
|
|||
| // Collect the legend entries. If multiple items have the same name, they share a | |||
| // checkbox. If their colors don't match, we pick a neutral color for the checkbox. | |||
| let mut entries: BTreeMap<String, LegendEntry> = BTreeMap::new(); | |||
| let mut keys: BTreeMap<String, usize> = BTreeMap::new(); | |||
| let mut entries: BTreeMap<(usize, String), LegendEntry> = BTreeMap::new(); | |||
There was a problem hiding this comment.
Using a tuple as a key feels weird, but I guess it makes sense in this case
lucasmerlin
reviewed
Feb 5, 2025
lucasmerlin
added
the
include in changelog
|
Ah, it needs a rebase since that one action got deprecated |
lucasmerlin
changed the title
insertion_orderinsertion_order and color_conflict_handling to Legend
Co-authored-by: lucasmerlin <lucasmeurer96@gmail.com>
bircni
force-pushed
the
legend_updates
branch
from
d37acc1 to
8de7fa1
Compare
|
@lucasmerlin rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #45 seems to be inactive I fixed the rest and now it should be ready to merge
insertion_orderandcolor_conflict_handlingtoLegend#45