Skip to content

Commit

Permalink
Apply changes from review
Browse files Browse the repository at this point in the history
  • Loading branch information
lucasmerlin committed Feb 4, 2025
1 parent ccba2b1 commit 8e958c4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
* text=auto eol=lf
Cargo.lock linguist-generated=false

*.png filter=lfs diff=lfs merge=lfs -text
*.png filter=lfs diff=lfs merge=lfs -text
3 changes: 2 additions & 1 deletion .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ jobs:

tests:
name: Run tests
# We run the tests on macOS because it will run with an actual GPU
# We run the tests on macOS because it will run with an actual GPU,
# which is needed by the egui_kittest snapshot tests.
runs-on: macos-latest

steps:
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ web-sys = "0.3.70"
# When we want to use the bleeding edge version of egui and eframe:
eframe = { git = "https://github.com/emilk/egui", branch = "master" }
egui = { git = "https://github.com/emilk/egui", branch = "master" }
emath = { git = "https://github.com/emilk/egui", branch = "master" }
egui_kittest = { git = "https://github.com/emilk/egui", branch = "master" }
emath = { git = "https://github.com/emilk/egui", branch = "master" }

# If you fork https://github.com/emilk/egui you can test with:
# eframe = { path = "../egui/crates/eframe" }
Expand Down
1 change: 1 addition & 0 deletions demo/src/plot_demo.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ impl PlotDemo {

// TODO(lucasmerlin): The parent ui should ideally be automatically set as AccessKit parent
// or at least, with an opt in via UiBuilder, making this much more readable
// See https://github.com/emilk/egui/issues/5674
ui.ctx()
.clone()
.with_accessibility_parent(container_response.id, || {
Expand Down

0 comments on commit 8e958c4

Please sign in to comment.