forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[C++20] [Modules] Don't handle no linkage entities when overloading
The original implementation uses `ND->getFormalLinkage() <= Linkage::InternalLinkage`. It is not right since the spec only says internal linkage and it doesn't mention 'no linkage'. This matters when we consider constructors. According to [class.ctor.general]p1, constructors have no name so constructors have no linkage too.
- Loading branch information
1 parent
0d191b7
commit 99daf6b
Showing
2 changed files
with
45 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
// RUN: rm -rf %t | ||
// RUN: split-file %s %t | ||
// RUN: cd %t | ||
// | ||
// RUN: %clang_cc1 -std=c++20 %t/A.cppm -I%t -emit-module-interface -o %t/A.pcm | ||
// RUN: %clang_cc1 -std=c++20 -fprebuilt-module-path=%t %t/Use.cpp -verify -fsyntax-only | ||
// | ||
//--- foo.h | ||
|
||
namespace ns { | ||
|
||
struct T { | ||
T(void*); | ||
}; | ||
|
||
struct A { | ||
template <typename F> | ||
A(F f) : t(&f) {} | ||
|
||
T t; | ||
}; | ||
|
||
template <typename T> | ||
void foo(T) { | ||
auto f = [](){}; | ||
ns::A a(f); | ||
} | ||
} | ||
|
||
//--- A.cppm | ||
module; | ||
#include "foo.h" | ||
export module A; | ||
export namespace ns { | ||
using ns::A; | ||
using ns::foo; | ||
} | ||
|
||
//--- Use.cpp | ||
// expected-no-diagnostics | ||
import A; | ||
void test() { | ||
ns::foo(5); | ||
} |