Skip to content

Commit

Permalink
[C++20] [Modules] Don't handle no linkage entities when overloading
Browse files Browse the repository at this point in the history
The original implementation uses `ND->getFormalLinkage() <=
Linkage::InternalLinkage`. It is not right since the spec only says
internal linkage and it doesn't mention 'no linkage'. This matters when
we consider constructors. According to [class.ctor.general]p1,
constructors have no name so constructors have no linkage too.
  • Loading branch information
ChuanqiXu9 committed Jul 26, 2022
1 parent 0d191b7 commit 99daf6b
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 1 deletion.
2 changes: 1 addition & 1 deletion clang/lib/Sema/SemaOverload.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6413,7 +6413,7 @@ void Sema::AddOverloadCandidate(
if (auto *SpecInfo = Function->getTemplateSpecializationInfo())
ND = SpecInfo->getTemplate();

if (ND->getFormalLinkage() <= Linkage::InternalLinkage) {
if (ND->getFormalLinkage() == Linkage::InternalLinkage) {
Candidate.Viable = false;
Candidate.FailureKind = ovl_fail_module_mismatched;
return;
Expand Down
44 changes: 44 additions & 0 deletions clang/test/Modules/ctor.arg.dep.cppm
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
// RUN: rm -rf %t
// RUN: split-file %s %t
// RUN: cd %t
//
// RUN: %clang_cc1 -std=c++20 %t/A.cppm -I%t -emit-module-interface -o %t/A.pcm
// RUN: %clang_cc1 -std=c++20 -fprebuilt-module-path=%t %t/Use.cpp -verify -fsyntax-only
//
//--- foo.h

namespace ns {

struct T {
T(void*);
};

struct A {
template <typename F>
A(F f) : t(&f) {}

T t;
};

template <typename T>
void foo(T) {
auto f = [](){};
ns::A a(f);
}
}

//--- A.cppm
module;
#include "foo.h"
export module A;
export namespace ns {
using ns::A;
using ns::foo;
}

//--- Use.cpp
// expected-no-diagnostics
import A;
void test() {
ns::foo(5);
}

0 comments on commit 99daf6b

Please sign in to comment.