Skip to content

Commit

Permalink
Revert "[MLIR] Add forgotten directory Support to unittests cmake"
Browse files Browse the repository at this point in the history
This reverts commit 0c553cc.

This caused a buildbot failure (https://lab.llvm.org/buildbot#builders/197/builds/888).

```
******************** TEST 'ScudoStandalone-Unit :: ./ScudoUnitTest-aarch64-Test/ScudoCommonTest.ResidentMemorySize' FAILED ********************
Script:
--
/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1/projects/compiler-rt/lib/scudo/standalone/tests/./ScudoUnitTest-aarch64-Test --gtest_filter=ScudoCommonTest.ResidentMemorySize
--
Note: Google Test filter = ScudoCommonTest.ResidentMemorySize
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ScudoCommonTest
[ RUN      ] ScudoCommonTest.ResidentMemorySize
/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/llvm/compiler-rt/lib/scudo/standalone/tests/common_test.cpp:49: Failure
Expected: (getResidentMemorySize()) > (OnStart + Size - Threshold), actual: 707358720 vs 943153152
[  FAILED  ] ScudoCommonTest.ResidentMemorySize (21709 ms)
[----------] 1 test from ScudoCommonTest (21709 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (21709 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ScudoCommonTest.ResidentMemorySize
 1 FAILED TEST
********************
```
  • Loading branch information
Superty committed Dec 26, 2021
1 parent aabe901 commit 2132906
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
3 changes: 2 additions & 1 deletion mlir/include/mlir/Support/DebugAction.h
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,8 @@ template <typename... ParameterTs> class DebugAction {

/// Provide classof to allow casting between handler types.
static bool classof(const DebugActionManager::HandlerBase *handler) {
return handler->getHandlerID() == TypeID::get<Handler>();
return handler->getHandlerID() ==
TypeID::get<DebugAction<ParameterTs...>::Handler>();
}
};

Expand Down
1 change: 0 additions & 1 deletion mlir/unittests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ add_subdirectory(ExecutionEngine)
add_subdirectory(Interfaces)
add_subdirectory(IR)
add_subdirectory(Pass)
add_subdirectory(Support)
add_subdirectory(Rewrite)
add_subdirectory(TableGen)
add_subdirectory(Transforms)
2 changes: 1 addition & 1 deletion mlir/unittests/Support/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ add_mlir_unittest(MLIRSupportTests
)

target_link_libraries(MLIRSupportTests
PRIVATE MLIRSupport)
PRIVATE MLIRSupportIndentedOstream MLIRSupport)

0 comments on commit 2132906

Please sign in to comment.