Truncate long lines #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Can we add three dots |
|
Good idea, I have added it as |
jcs090218
approved these changes
Nov 3, 2024
|
LGTM! Thank you for your contribution! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a setting to allow truncation. Fixes #24 (see latest comment)
Truncation is available on lines that have at least
sideline-truncate-min-available-space-ratioof available space (50% by default).The minium available space check is made to avoid the case where there is very few space available on the next line. The message would be almost non visible.
We could also find the longest line if the message doesn't fit but that seemed a bit too complicated to implement, and this seems to work well.
WDYT?