Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring all-the-icons functions #4588

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wyuenho
Copy link
Contributor

@wyuenho wyuenho commented Oct 19, 2024

lsp-modeline--code-actions-icon isn't guarded by the proper checks for all-the-icons-octicon function, which will cause all-the-icons to load in the terminal, even though it is not supported. I've also taken the opportunity to refactor the 2 functions that use all-the-icons to use the new lsp-icons-all-the-icons-icon function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant