-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eask lint elsa issues #219
Comments
I also encountered this (though running via LSP with Cask) when I've tried wiring up some of my own packages with Elsa. I'm wholly unfamiliar with the internals of Elsa, but it appears that it's choking on analyzing the |
It's weird. It seems like melpa doesn't recognize the new dependencies from elsa. See https://melpa.org/#/elsa. It's missing Line 9 in 2aa912d
cc @tarsius Do you know why? |
This is most likely not Eask related and there is simply some code that Elsa chokes on. It still happens quite often as it's hard to get all the edge-cases accounted for. What is your exact versions of Emacs? Since the source can be different between each commit, ideally maybe upload your subr.el somewhere exactly as it appears on your system so I can try to run it locally and see what happens. |
Package-Build uses |
@Fuco1 Emacs 28.1.91
|
Yep, you are right, It's most probably because of some code that Elsa can not properly understand. But should Elsa just fail to continue in such cases? I think it would be better if Elsa mark some libraries as 'broken' and skip them in further processing instead. I propose Elsa to catch such exceptions and mark such 'bad' libraries somehow and continue to work with collected information ignoring 'broken' libraries.
My exact version of Emacs is brew installed emacs-plus@28/28.2 on MacOS. My Thank you. |
This is indeed the idea and there is some level of error handling. The two main issues are: reader issues where there is some weird syntax that Elsa cannot parse. This is usually what causes a crash. Another issue is straight up bugs in Elsa itself, so that we actually have ie type errors in our code 😊 Each analysed form should be wrapped with try-catch. The OP error in fact points to a problem with Elsa itself, since it says The weirder thing still is that I tried the subr code and it passed on my version, but it might be slightly different. One other thing you can try is to delete the |
eask
version 0.8.1elsa
version 20230318.2024When trying to run
eask lint elsa
first received errors about missing dependenciesasync
andlgr
. Added as dev dependencies to myEask
file and performeask install-deps --dev
. After that elsa looks like started and here is the output:Any ideas how this could be fixed?
The text was updated successfully, but these errors were encountered: