[HPCG-329] pagination component #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhittle933
requested changes
Apr 10, 2023
| #[derive(Properties, Clone, PartialEq)] | ||
| pub struct Props { | ||
| #[prop_or_default] | ||
| pub callback: Callback<u32>, |
There was a problem hiding this comment.
I would name this prop something more informative in the callback style, on_click_page or on_select_page. Something like that.
glitchy
force-pushed
the
lj/pagination-component
branch
3 times, most recently
from
986e933 to
2ebde70
Compare
glitchy
force-pushed
the
lj/pagination-component
branch
from
2ebde70 to
ce88f04
Compare
bcmcmill
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding pagination component