fix: imbuement shrine use on non-item objects (opentibiabr#905)

Fix undefined behaviour when you use the imbuement shrine on a non item type.
elsongabriel · Mar 6, 2023 · fe9419c · fe9419c
1 parent 3a5e038
commit fe9419c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/data-canary/scripts/actions/imbuement_shrine.lua b/data-canary/scripts/actions/imbuement_shrine.lua
@@ -5,6 +5,10 @@ function imbuement.onUse(player, item, fromPosition, target, toPosition, isHotke
 		return player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You did not collect enough knowledge from the ancient Shapers. Visit the Shaper temple in Montag for help.")
 	end
 
+	if not(target) or not(target:isItem()) then
+		return player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You can only use the shrine on an valid item.")
+	end
+
 	player:openImbuementWindow(target)
 	return true
 end

diff --git a/data-otservbr-global/scripts/actions/object/imbuement_shrine.lua b/data-otservbr-global/scripts/actions/object/imbuement_shrine.lua
@@ -5,6 +5,10 @@ function imbuement.onUse(player, item, fromPosition, target, toPosition, isHotke
 		return player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You did not collect enough knowledge from the ancient Shapers. Visit the Shaper temple in Thais for help.")
 	end
 
+	if not(target) or not(target:isItem()) then
+		return player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You can only use the shrine on an valid item.")
+	end
+
 	player:openImbuementWindow(target)
 	return true
 end